patch/non-evm-support-devtools-move #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors address format handling to support multiple blockchain encodings (EVM hex, Solana base58, TON base64) through auto-detection rather than endpoint ID-based chain type checking. The key improvement is a unified basexToBytes32() function that automatically detects and converts any supported address format to a consistent bytes32 representation.
Key Changes:
- Replaced chain-type-based address conversion with automatic format detection
- Unified all address comparison and conversion operations to use
basexToBytes32() - Removed now-redundant helper functions (
formatAddress,evmAddressToAptos,decodeSolanaAddress)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/devtools-move/tasks/shared/basexToBytes32.ts | Complete refactor with auto-detection logic for base58, base64, and hex formats; removed endpoint ID parameter |
| packages/devtools-move/tasks/move/utils/moveVMOftConfigOps.ts | Replaced formatAddress and evmAddressToAptos with basexToBytes32 throughout; removed obsolete helper functions |
| packages/devtools-move/tasks/evm/wire-evm.ts | Updated basexToBytes32 call to remove endpoint ID parameter |
| packages/devtools-move/jest/baseXtoBytes32.test.ts | Rewrote tests to validate auto-detection behavior instead of chain-type-specific conversions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TRileySchwarz
force-pushed
the
patch/non-evm-support-devtools-move
branch
from
9737049 to
b7f945f
Compare
Signed-off-by: shankar <[email protected]>
Signed-off-by: shankar <[email protected]>
Signed-off-by: shankar <[email protected]>
Signed-off-by: shankar <[email protected]>
shankars99
force-pushed
the
patch/non-evm-support-devtools-move
branch
from
e47dc3c to
6f0b4f5
Compare
TRileySchwarz
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning addresses based on
eidparse them based on their encoding by padding tobytes32or frombase58for Solana.Signed-off-by: shankar [email protected]